ARM: dts: sun7i: a20: bananapro: Fix ethernet node

Jernej Škrabec jernej.skrabec at siol.net
Wed Jan 20 18:48:04 EST 2021


Hi!

Change itself it's fine, just few comments on your commit message and e-mail 
recipients.

Dne sreda, 20. januar 2021 ob 12:40:26 CET je Hermann.Lauer at uni-heidelberg.de 
napisal(a):
> BananaPro 1GB works only reliable with the patch for M2 Ultra applied to
> it's devicetree, too. Without this patch you will get high packet loss 
rates.

M2 Ultra has nothing to do with BananaPro, it's better to explain real reason 
why this change fixes ethernet.

> 
> Tested-by: Hermann Lauer <Hermann.Lauer at uni-heidelberg.de>

Tested-by tag from the patch author is not very useful, it's already expected 
that you (or person you know) tested it, when sending fixes.

> 
> From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001
> From: Jernej Skrabec <jernej.skrabec at siol.net>
> Date: Sun, 25 Oct 2020 09:19:49 +0100
> Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node

As I said, referencing fix for another, unrelated board is not really 
meaningful.

> 
> Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix
> ethernet node to reflect that fact.
> 
> Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC 
ethernet controller")

Fixes tag is for M2 Ultra and completely irrelevant here. Please provide 
proper Fixes tag for this file.

You are missing Signed-of-by tag at the end of the message.

You missed few maintainers and mailing lists in "to" and "cc" field. Run 
"scripts/get_maintainer.pl" on this patch to get full list of recipients.

Best regards,
Jernej





More information about the linux-arm-kernel mailing list