[PATCH V1 3/4] perf vendor events: Add JSON metrics for imx8mq DDR Perf

[Joakim Zhang]

> -----Original Message-----
> From: John Garry <john.garry at huawei.com>
> Sent: 2021年1月19日 18:40
> To: Joakim Zhang <qiangqing.zhang at nxp.com>; acme at kernel.org;
> jolsa at redhat.com
> Cc: will at kernel.org; linux-perf-users at vger.kernel.org; dl-linux-imx
> <linux-imx at nxp.com>; mark.rutland at arm.com;
> linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH V1 3/4] perf vendor events: Add JSON metrics for imx8mq
> DDR Perf
> 
> On 19/01/2021 02:56, Joakim Zhang wrote:
> > index 000000000000..c3e9f89a4a4d
> > --- /dev/null
> > +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx8mq/sys/metrics.js
> > +++ on
> > @@ -0,0 +1,26 @@
> > +[
> > +   {
> > +	    "BriefDescription": "bandwidth usage for lpddr4 evk board",
> 
> Why mention the evk board specifically? Is this metric only specific to that
> board, and not all i.MX8MQ platforms?

Yes, John, we have lpddr4 evk board and ddr4 evk borad......

John, change to your new framework, I found it can't support all features which is supported in 5.10 kernel.

Best Regards,
Joakim Zhang
> Thanks,
> John
> 
> > +	    "MetricName": "imx8mq_bandwidth_usage.lpddr4",
> > +	    "MetricExpr": "(( imx8_ddr0 at read\\-cycles@ +
> imx8_ddr0 at write\\-cycles@ ) * 4 * 4 / duration_time) / (800 * 1000000 * 4 *
> 4)",
> > +	    "ScaleUnit": "1e2%",
> > +	    "Unit": "imx8_ddr",
> > +	    "Compat": "i.MX8MQ"
> > +   },