[PATCH] dt-bindings: irqchip: Add #address-cells to PRUSS INTC
Suman Anna
s-anna at ti.com
Fri Jan 15 15:58:19 EST 2021
The '#address-cells' property looks to be a required property for
interrupt controller nodes as indicated by a warning message seen
when building dtbs with W=2. Adding the property to the PRUSS INTC
dts nodes though fails the dtbs_check. Add this property to the
PRUSS INTC binding to make it compliant with both dtbs_check and
building dtbs.
Signed-off-by: Suman Anna <s-anna at ti.com>
---
Hi Rob,
This patch is also part of our effort to get rid of the warnings seen
around interrupt providers on TI K3 dtbs [1]. I needed this in the PRUSS
INTC bindings to not get a warning with dtbs_check while also ensuring
no warnings while building dtbs with W=2.
I would have expected the '#address-cells' requirement to be inherited
automatically. And looking through the schema files, I actually do not
see the interrupt-controller.yaml included automatically anywhere. You
had asked us to drop the inclusion in this binding in our first version
with YAML [3]. Am I missing something, and how do we ensure that this
is enforced automatically for everyone?
regards
Suman
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115083003.27387-1-lokeshvutla@ti.com/
[2] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/
[3] https://patchwork.kernel.org/comment/23484523/
.../bindings/interrupt-controller/ti,pruss-intc.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml
index c2ce215501a5..dcbfe08e997d 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml
@@ -79,6 +79,9 @@ properties:
mapping and channels to host interrupts so through this property entire
mapping is provided.
+ "#address-cells":
+ const: 0
+
ti,irqs-reserved:
$ref: /schemas/types.yaml#/definitions/uint8
description: |
@@ -100,6 +103,7 @@ required:
- interrupt-names
- interrupt-controller
- "#interrupt-cells"
+ - "#address-cells"
additionalProperties: false
@@ -123,6 +127,7 @@ examples:
"host_intr6", "host_intr7";
interrupt-controller;
#interrupt-cells = <3>;
+ #address-cells = <0>;
};
};
@@ -142,6 +147,7 @@ examples:
reg = <0x20000 0x2000>;
interrupt-controller;
#interrupt-cells = <3>;
+ #address-cells = <0>;
interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>,
--
2.29.2
More information about the linux-arm-kernel
mailing list