[PATCH v2] crypto: reduce minimum alignment of on-stack structures

Ard Biesheuvel ardb at kernel.org
Wed Jan 13 03:18:31 EST 2021


On Wed, 13 Jan 2021 at 07:27, Herbert Xu <herbert at gondor.apana.org.au> wrote:
>
> On Fri, Jan 08, 2021 at 11:49:32PM +0100, Ard Biesheuvel wrote:
> >
> > The assumption is that ARCH_SLAB_MINALIGN should be sufficient for any
> > POD type, But I guess that in order to be fully correct, the actual
> > alignment of the struct type should be ARCH_SLAB_MINALIGN, and __ctx
> > should just be padded out so it appears at an offset that is a
> > multiple of ARCH_KMALLOC_ALIGN.
>
> How about just leaving the skcpiher alone for now and change shash
> only?
>

Good point. I'll spin a v3 with only the shash_desc change and the
updated comment for CRYPTO_MINALIGN.



More information about the linux-arm-kernel mailing list