[PATCH 5/5] gpio: mvebu: document zero pwm duty cycle limitation
Baruch Siach
baruch at tkos.co.il
Mon Jan 11 06:17:06 EST 2021
Add a comment on why the code never sets the 'on' register to zero.
Reported-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Signed-off-by: Baruch Siach <baruch at tkos.co.il>
---
drivers/gpio/gpio-mvebu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index eb7456fa6d86..4261e3b22b4e 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -706,6 +706,7 @@ static int mvebu_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
val = DIV_ROUND_UP_ULL(val, NSEC_PER_SEC);
if (val > UINT_MAX)
return -EINVAL;
+ /* zero 'on' value does not work as expected for some reason */
if (val)
on = val;
else
--
2.29.2
More information about the linux-arm-kernel
mailing list