[PATCH 1/2] dt-bindings: watchdog: change node name to generic

[Gowtham A Tammana]

Nishanth Menon wrote:
> On 18:07-20201216, Gowtham Tammana wrote:
> > Modifying the example to use generic as node name to keep it consistent
> ^^ Please don't state in commit message the actual change you are
> doing.. We can see that from the diffstat. There are lots of
> documentation now a days on smart commit messages, I suggest reading
> those.
> 
> > with the generic name recommendation.
> 
> 
> I think what you are doing here is to fix a typo in the example
> provided to match with the compatible that is supposed to be used.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26
> 
> While this change is valid, please:
> a) Rewrite the commit message
> b) Fix $subject "dt-bindings: watchdog: change node name to generic"
> "dt-bindings: watchdog" is a huge range of watchdog driver scope, you
> want to narrow it to the ti,rti
> dt-bindings: watchdog: ti,rti:" or What ever wdt/dt maintainers may prefer.
> 
> "change node name to generic" -> yes, diff tells us that, you are trying
> to fix a typo in the example, so please use the word fix to indicate
> this is a fixup, not a new 'change' ..
> 
> c) Please CC subsystem maintainers.. I suppose these go through
> subsystem maintainer trees once Rob Acks..

Thanks for the review here Nishant. Will make the suggested changes for v2.

Gowtham
> 
> > 
> > Signed-off-by: Gowtham Tammana <g-tammana at ti.com>
> > ---
> >  Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > index c1348db59374..e21af390b3e9 100644
> > --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > @@ -57,8 +57,8 @@ examples:
> >       */
> >      #include <dt-bindings/soc/ti,sci_pm_domain.h>
> >  
> > -    watchdog0: rti at 2200000 {
> > -        compatible = "ti,rti-wdt";
> > +    watchdog0: watchdog at 2200000 {
> > +        compatible = "ti,j7-rti-wdt";
> >          reg = <0x2200000 0x100>;
> >          clocks = <&k3_clks 252 1>;
> >          power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> > -- 
> > 2.29.0
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D