[PATCH 5/6] gpiolib: Fix return check of __irq_domain_alloc_irqs

Andy Shevchenko andy.shevchenko at gmail.com
Mon Jan 4 10:00:52 EST 2021


On Sat, Jan 2, 2021 at 8:24 PM Adam Lackorzynski <adam at l4re.org> wrote:
>
> 0 is not a proper IRQ number and also indicates failure.

Hmm... While in this case it's perhaps okay, this does not work in
general since the function can take irq_base == 0 and realloc == true.
So if we want to have a code that somebody may reuse better not to do
this (we never get 0 from this function).

In my humble opinion NAK.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list