[PATCH 4/6] irqchip/ixp4xx: Fix return check of __irq_domain_alloc_irqs

Adam Lackorzynski adam at l4re.org
Sat Jan 2 12:58:57 EST 2021


0 is not a proper IRQ number and also indicates failure.

Signed-off-by: Adam Lackorzynski <adam at l4re.org>
---
 drivers/irqchip/irq-ixp4xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-ixp4xx.c b/drivers/irqchip/irq-ixp4xx.c
index 37e0749215c7..54dcffe2309f 100644
--- a/drivers/irqchip/irq-ixp4xx.c
+++ b/drivers/irqchip/irq-ixp4xx.c
@@ -355,7 +355,7 @@ void __init ixp4xx_irq_init(resource_size_t irqbase,
 					      &fwspec,
 					      false,
 					      NULL);
-		if (ret < 0) {
+		if (ret <= 0) {
 			pr_crit("IXP4XX: can not allocate irqs in hierarchy %d\n",
 				ret);
 			return;
-- 
2.30.0.rc2




More information about the linux-arm-kernel mailing list