small oddity in commit "power: reset: add driver for LinkStation power off"

[Daniel González Cabanelas]

El jue, 18 feb 2021 a las 18:39, Daniel Golle
(<daniel at makrotopia.org>) escribió:
>
> Hi Daniel,
>
> I stumbled upon a slight oddity in acommit you have contributed.
> Please see my comment below.
>
> > commit a7f79f99541eff4e6bcae0014eb08d3019337565
> > Author: Daniel González Cabanelas <dgcbueu at gmail.com>
> > Date:   Wed Jul 15 15:35:14 2020 +0200
> >
> >     power: reset: add driver for LinkStation power off
> >
> >     Some Buffalo LinkStations perform the power off operation, at restart
> >     time, depending on the state of an output pin (LED2/INTn) at the ethernet
> >     PHY. This pin is also used to wake the machine when a WoL packet is
> >     received by the PHY.
> >
> >     The driver is required by the Buffalo LinkStation LS421DE (ARM MVEBU),
> >     and other models. Without it, the board remains forever halted if a
> >     power off command is executed, unless the PSU is disconnected and
> >     connected again.
> >
> >     Add the driver to provide the power off function and also make the WoL
> >     feature to be available.
> >
> >     Signed-off-by: Daniel González Cabanelas <dgcbueu at gmail.com>
> >     Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> > ...
> > diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
> > index 5710ca4695170..c51eceba9ea39 100644
> > --- a/drivers/power/reset/Makefile
> > +++ b/drivers/power/reset/Makefile
> > @@ -10,6 +10,7 @@ obj-$(CONFIG_POWER_RESET_GEMINI_POWEROFF) += gemini-poweroff.o
> >  obj-$(CONFIG_POWER_RESET_GPIO) += gpio-poweroff.o
> >  obj-$(CONFIG_POWER_RESET_GPIO_RESTART) += gpio-restart.o
> >  obj-$(CONFIG_POWER_RESET_HISI) += hisi-reboot.o
> > +obj-${CONFIG_POWER_RESET_LINKSTATION} += linkstation-poweroff.o
>
> Why are you using curly brackets (ie. shell variable) here instead of
> normal parentheses (ie. Make variable)? It might work, but if there is
> no special reason for this, we should just be consistent with the rest
> of the file.

Hi Daniel. Indeed there is no reason to use curly brackets.

I have no idea why I commited this small mistake, probably I need to
graduate my glasses. Feel free to send a patch to fix it.

Thank you
Daniel
>
>
> Cheers
>
>
> Daniel