[PATCH v7 1/3] scmi-cpufreq: Remove deferred probe
Nicola Mazzucato
nicola.mazzucato at arm.com
Mon Feb 15 02:51:37 EST 2021
The current implementation of the scmi_cpufreq_init() function returns
-EPROBE_DEFER when the OPP table is not populated. In practice the
cpufreq core cannot handle this error code.
Therefore, fix the return value and clarify the error message.
Reviewed-by: Ionela Voinescu <ionela.voinescu at arm.com>
Signed-off-by: Nicola Mazzucato <nicola.mazzucato at arm.com>
---
drivers/cpufreq/scmi-cpufreq.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index 491a0a24fb1e..34bf2eb8d465 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -155,9 +155,11 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
if (nr_opp <= 0) {
- dev_dbg(cpu_dev, "OPP table is not ready, deferring probe\n");
- ret = -EPROBE_DEFER;
- goto out_free_opp;
+ dev_err(cpu_dev, "%s: No OPPs for this device: %d\n",
+ __func__, ret);
+
+ ret = -ENODEV;
+ goto out_free_priv;
}
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
--
2.27.0
More information about the linux-arm-kernel
mailing list