[EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

Stefan Chulski stefanc at marvell.com
Thu Feb 11 08:02:14 EST 2021



> -----Original Message-----
> From: Russell King - ARM Linux admin <linux at armlinux.org.uk>
> Sent: Thursday, February 11, 2021 2:50 PM
> To: Stefan Chulski <stefanc at marvell.com>
> Cc: netdev at vger.kernel.org; thomas.petazzoni at bootlin.com;
> davem at davemloft.net; Nadav Haklai <nadavh at marvell.com>; Yan
> Markman <ymarkman at marvell.com>; linux-kernel at vger.kernel.org;
> kuba at kernel.org; mw at semihalf.com; andrew at lunn.ch;
> atenart at kernel.org; devicetree at vger.kernel.org; robh+dt at kernel.org;
> sebastian.hesselbarth at gmail.com; gregory.clement at bootlin.com; linux-
> arm-kernel at lists.infradead.org
> Subject: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non
> occupied descriptor threshold
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, Feb 11, 2021 at 12:48:55PM +0200, stefanc at marvell.com wrote:
> > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > index 761f745..8b4073c 100644
> > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > @@ -1133,14 +1133,19 @@ static inline void
> > mvpp2_qvec_interrupt_disable(struct mvpp2_queue_vector *qvec)  static
> > void mvpp2_interrupts_mask(void *arg)  {
> >  	struct mvpp2_port *port = arg;
> > +	int cpu = smp_processor_id();
> > +	u32 thread;
> >
> >  	/* If the thread isn't used, don't do anything */
> > -	if (smp_processor_id() > port->priv->nthreads)
> > +	if (cpu > port->priv->nthreads)
> >  		return;
> 
> What happened to a patch fixing this? Did I miss it? Was it submitted
> independently to the net tree?

Some reviewers asked to remove this from the series. I would send it as separate patch to net.

Regards.



More information about the linux-arm-kernel mailing list