[PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

Tony Lindgren tony at atomide.com
Wed Feb 10 05:19:25 EST 2021


* Hector Martin 'marcan' <marcan at marcan.st> [210208 12:05]:
> On 08/02/2021 20.04, Krzysztof Kozlowski wrote:
...

> > > +	clk24: clk24 {
> > 
> > Just "clock". Node names should be generic.
> 
> Really? Almost every other device device tree uses unique clock node names.

Yeah please just use generic node name "clock". FYI, we're still hurting
because of this for the TI clock node names years after because the drivers
got a chance to rely on the clock node name..

Using "clock" means your clock driver code won't get a chance to wrongly
use the node name and you avoid similar issues.

Regards,

Tony




More information about the linux-arm-kernel mailing list