[PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options.
grygorii.strashko at ti.com
Fri Feb 5 10:04:08 EST 2021
On 05/02/2021 16:46, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko at ti.com> [210205 14:25]:
>> On 05/02/2021 15:30, Tony Lindgren wrote:
>>> Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig
>>> for the other cases that do not use KS8851?
>> The KS8851 config was added like 10years ago and is used on some omap4 platforms,
>> it does select MICREL_PHY.
>> From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851.
>> The omap2plus_defconfig is also used as base for custom configs and first thing people are doing -
>> remove not needed options. As result, removal of KS8851 plus this patch will immediately
>> cause MICREL_PHY=n and so breakage on existing and custom platforms.
>> I do not see how it can be resolved by using Kconfig changes within much-omap2.
>> So, sry, but NACK for this patch as it is.
> We can wait on this patch no problem while we figure this out.
> But certainly we need to fix things so make savedefconfig
> produces valid configs that don't need to be manually edited.
>> if some Kconfig dependencies need to be sorted out - probably the best way might be
>> to get rid of select MICREL_PHY in KS8851/KS8851_MLL.
> That will potentially break things too as the configs now expect
> it to be selected :) Looks like that got changed with commit
> f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in
Yah. It's really has to be "depends on".
> So why can't we do similar patches to select MICREL_PHY for
> the other non-ks8851 configurations in drivers/net/ethernet
> Kconfig files as needed?
because there is no dependency between Ethernet controller (CPSW) and
Ethernet PHY - any MII capable PHY can be used with CPSW.
More information about the linux-arm-kernel