[PATCH] pinctrl: imx: fix assigning groups names
Rafał Miłecki
zajec5 at gmail.com
Mon Dec 27 04:22:37 PST 2021
From: Rafał Miłecki <rafal at milecki.pl>
This fixes regression caused by incorrect array indexing.
Reported-by: Fabio Estevam <festevam at gmail.com>
Fixes: 02f117134952 ("pinctrl: imx: prepare for making "group_names" in "function_desc" const")
Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
---
drivers/pinctrl/freescale/pinctrl-imx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 16bc1bfc03e4..fa3cc0b80ede 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -649,7 +649,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
struct function_desc *func;
struct group_desc *grp;
const char **group_names;
- u32 i = 0;
+ u32 i;
dev_dbg(pctl->dev, "parse function(%d): %pOFn\n", index, np);
@@ -669,10 +669,12 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
sizeof(char *), GFP_KERNEL);
if (!group_names)
return -ENOMEM;
+ i = 0;
for_each_child_of_node(np, child)
- group_names[i] = child->name;
+ group_names[i++] = child->name;
func->group_names = group_names;
+ i = 0;
for_each_child_of_node(np, child) {
grp = devm_kzalloc(ipctl->dev, sizeof(struct group_desc),
GFP_KERNEL);
--
2.31.1
More information about the linux-arm-kernel
mailing list