[PATCH V2] arm64: Fix early pointer print plus improve comment

[Guilherme G. Piccoli]

On 21/12/2021 12:27, Robin Murphy wrote:
> [...]
> Strictly it *is* the right modifier, since users who want to see 
> unhashed pointers should pass "no_hash_pointer" on the command line.
> 
> However, in this particular instance, the information leakage concern 
> does not apply since we're facing such a catastrophic failure that the 
> kernel can't even run - there's nothing for an attacker to attack! This 
> is effectively a last-gasp panic message to help debug bootloader issues 
> beyond the kernel's control, so it seems reasonable not to hamper it 
> with kernel-debugging machinery.
> 
> It might be worth spelling out the rationale clearly, at least in the 
> commit message, so it's there for easy future reference if someone comes 
> along with a "%px is bad, change it back" patch. "Hashed address stuff" 
> on its own isn't really a reason.
> 

OK Robin, thanks for the review again, I agree with you and will resubmit.


>> [...]
> 
> Nit: I think we prefer normal-style comments (i.e. "/*" on its own line 
> to start) in arch code.
> 
> Otherwise, it all seems reasonable - thanks for clearing it up.
> 
> Robin.

Cool, will fix that also in the V3 =)
Cheers,


Guilherme