[PATCH v3 4/5] gpio: msc313: Add support for SSD201 and SSD202D

Daniel Palmer daniel at 0x0f.com
Mon Dec 20 07:02:04 PST 2021


Hi Bartosz,

On Mon, 20 Dec 2021 at 23:50, Bartosz Golaszewski <brgl at bgdev.pl> wrote:
>
> On Mon, Dec 13, 2021 at 10:40 AM Daniel Palmer <daniel at 0x0f.com> wrote:
> >
> > This adds GPIO support for the SSD201 and SSD202D chips.
> >
> > Signed-off-by: Daniel Palmer <daniel at 0x0f.com>
> > Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
> > ---
>
> I applied patches 1-3. This triggers a bunch of checkpatch errors.
> Please address them and resend this single patch.

The warnings about complex macros being wrapped in parentheses when
the things it's complaining about are defined lists not macros?
Not going to say I know better than checkpatch but I think the errors
there are wrong. Putting parentheses around the lists would break the
arrays they get put into.

Cheers,

Daniel



More information about the linux-arm-kernel mailing list