[PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs

[Radhey Shyam Pandey]

+ Harini

> -----Original Message-----
> From: Russell King <linux at armlinux.org.uk>
> Sent: Thursday, December 16, 2021 10:32 PM
> To: Jakub Kicinski <kuba at kernel.org>
> Cc: Michal Simek <michals at xilinx.com>; Radhey Shyam Pandey
> <radheys at xilinx.com>; Sean Anderson <sean.anderson at seco.com>; David S.
> Miller <davem at davemloft.net>; netdev at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs
> 
> On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote:
> > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote:
> > > Convert axienet to use the phylink_pcs layer, resulting in it no
> > > longer being a legacy driver.
> > >
> > > One oddity in this driver is that lp->switch_x_sgmii controls
> > > whether we support switching between SGMII and 1000baseX. However,
> > > when clear, this also blocks updating the 1000baseX advertisement,
> > > which it probably should not be doing. Nevertheless, this behaviour
> > > is preserved but a comment is added.
> > >
> > > Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> >
> > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function
> parameter or member 'pcs' not described in 'axienet_local'
> 
> Fixed that and the sha1 issue you raised in patch 2. Since both are
> "documentation" issues, I won't send out replacement patches until I've heard
> they've been tested on hardware though.

Thanks, series looks fine. I have added Harini to this thread and she will
confirm it on hardware.
> 
> Thanks!
> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!