[PATCH v3 2/2] arm64: Unconditionally override SYM_FUNC macros

Mark Brown broonie at kernel.org
Tue Dec 14 06:28:00 PST 2021


On Tue, Dec 14, 2021 at 03:12:01PM +0100, Ard Biesheuvel wrote:
> On Tue, 14 Dec 2021 at 15:10, Will Deacon <will at kernel.org> wrote:

> > I don't have a strong opinion here, so whatever you like. I just tend to
> > think that most people will have BTI enabled and there's something to be
> > said for having an instruction always emitted when you have a token in
> > assembly code.

> +1

> I already pointed out computed gotos, which are admittedly rare, but
> there are other reasons why adhering to WYSIWYG is strongly preferred
> for asm code IMO.

The use case for this macro is for SYM_FUNC_START() which is going to be
emitting the BTI without it really appearing directly in the code so I'm
not sure how much I buy that TBH.  I think you're pushing back on uses
of the macro outside of linkage.h more than on what linkage.h is doing,
that does make more sense to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20211214/a7147fde/attachment.sig>


More information about the linux-arm-kernel mailing list