[PATCH v2 1/2] mmc: sdhci-pci-gli: GL9755: Support for CD/WP inversion on OF platforms

[Adrian Hunter]

On 14/12/2021 13:17, Hector Martin wrote:
> On 14/12/2021 19.41, Adrian Hunter wrote:
>>>   #define PCI_GLI_9755_PECONF   0x44
>>> -#define   PCI_GLI_9755_LFCLK    GENMASK(14, 12)
>>> -#define   PCI_GLI_9755_DMACLK   BIT(29)
>>> +#define   PCI_GLI_9755_LFCLK          GENMASK(14, 12)
>>> +#define   PCI_GLI_9755_DMACLK         BIT(29)
>>
>> Please don't mix in white space changes.
> 
> This is aligning the existing code with the additions; is it preferable to have the new ifdefs below misaligned?

White space changes should be a separate patch

> 
>>> +#define   PCI_GLI_9755_INVERT_CD      BIT(30)
>>> +#define   PCI_GLI_9755_INVERT_WP      BIT(31)
>>>     #define PCI_GLI_9755_CFG2          0x48
>>>   #define   PCI_GLI_9755_CFG2_L1DLY    GENMASK(28, 24)
>>> @@ -570,6 +573,18 @@ static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
>>>       gl9755_wt_on(pdev);
>>>         pci_read_config_dword(pdev, PCI_GLI_9755_PECONF, &value);
>>> +#ifdef CONFIG_OF
>>> +    if (pdev->dev.of_node) {
>>
>> As Robin wrote, please remove #ifdef and if (pdev->dev.of_node)
>> because they are not needed.
> 
> Ack, will send out a v3 soon with the requested changes and hopefully it should be good to go :)
>