[PATCH v3 2/2] arm64: Unconditionally override SYM_FUNC macros

Mark Brown broonie at kernel.org
Mon Dec 13 11:21:25 PST 2021


On Mon, Dec 13, 2021 at 06:46:54PM +0000, Will Deacon wrote:
> On Wed, Dec 08, 2021 at 04:08:19PM +0000, Mark Brown wrote:

> > --- a/arch/arm64/include/asm/linkage.h
> > +++ b/arch/arm64/include/asm/linkage.h
> > @@ -8,10 +8,18 @@
> >  
> >  #define BTI_C bti c ;
> >  
> > +#else
> > +
> > +#define BTI_C
> > +
> > +#endif

> Why do we need this hunk? Having the hint instruction should be fine, no?

We could unconditionally insert the hint but that would be a step back
from what we currently have and would mean that hand written assembly
would be that little bit worse than what the compiler outputs.  If this
had been causing us issues I could see simplifying but I'm not aware of
any - the issues I'm aware of have been due to not adding the landing
pads in SYM_CODE, not SYM_FUNC.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20211213/fbdb7bb8/attachment.sig>


More information about the linux-arm-kernel mailing list