[PATCH] arm64: dts: qcom: ipq6018: Fix gpio-ranges property
Bryan O'Donoghue
pure.logic at nexus-software.ie
Sun Dec 12 07:44:34 PST 2021
On 07/12/2021 07:27, Baruch Siach wrote:
> There must be three parameters in gpio-ranges property. Fixes this not
> very helpful error message:
>
> OF: /soc/pinctrl at 1000000: (null) = 3 found 3
>
> Fixes: 1e8277854b49 ("arm64: dts: Add ipq6018 SoC and CP01 board support")
> Cc: Sricharan R <sricharan at codeaurora.org>
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> ---
>
> The error message was improved in commit af3be70a321 ("of: Improve
> of_phandle_iterator_next() error message"), but there is evidently some
> more room for improvement. As I don't really understand the code, I
> added the commit author and the DT list to Cc.
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 6a22bb5f42f4..a717fc17523d 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -220,7 +220,7 @@ tlmm: pinctrl at 1000000 {
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> - gpio-ranges = <&tlmm 0 80>;
> + gpio-ranges = <&tlmm 0 0 80>;
> interrupt-controller;
> #interrupt-cells = <2>;
>
>
Works for me
Tested-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>
More information about the linux-arm-kernel
mailing list