[PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver

[Miquel Raynal]

Hi Ralph,

ralph.siemsen at linaro.org wrote on Wed, 1 Dec 2021 16:18:50 -0500:

> On Fri, Nov 26, 2021 at 03:06:24PM +0100, Miquel Raynal wrote:
> >Introduce Renesas RZ/N1x NAND controller driver which supports:
> >- All ONFI timing modes
> >- Different configurations of its internal ECC controller
> >- On-die (not tested) and software ECC support
> >- Several chips (not tested)
> >- Subpage accesses
> >- DMA and PIO
> >
> >This controller was originally provided by Evatronix before being bought
> >by Cadence.
> >
> >Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>  
> 
> I've given it a try and all seems to be well. Thus:
> Tested-by: Ralph Siemsen <ralph.siemsen at linaro.org>

Great! Thanks for your feedback.

> >+	mtd = nand_to_mtd(chip);
> >+	mtd->dev.parent = nandc->dev;
> >+	if (!mtd->name) {
> >+		dev_err(nandc->dev, "Missing MTD label\n");
> >+		return -EINVAL;
> >+	}  
> 
> Minor item: could the node name be used as a fallback when label is not present?

That's not the policy that we tried to enforce so far because node
names are too generic and define the nand-controller, not the chip
itself. That is something which may evolve if we ever decide to do
things differently at some point but I guess we would need to do that
at MTD level in this case.

Thanks,
Miquèl