[PATCH v3 3/3] firmware: xilinx: Add sysfs support for feature config

[Ronak Jain]

Hi Greg KH,

Thanks for reviewing the patch.

> -----Original Message-----
> From: Greg KH <gregkh at linuxfoundation.org>
> Sent: Friday, December 3, 2021 2:52 PM
> To: Ronak Jain <ronakj at xilinx.com>
> Cc: Michal Simek <michals at xilinx.com>; linux-kernel at vger.kernel.org; Rajan
> Vaja <RAJANV at xilinx.com>; corbet at lwn.net; linux-arm-
> kernel at lists.infradead.org; arnd at arndb.de; Sai Krishna Potthuri
> <lakshmis at xilinx.com>
> Subject: Re: [PATCH v3 3/3] firmware: xilinx: Add sysfs support for feature
> config
> 
> On Fri, Dec 03, 2021 at 01:18:14AM -0800, Ronak Jain wrote:
> > Add support for sysfs interface for runtime features configuration.
> >  The user can configure the features at runtime. First the user need
> > to select the config id of the supported features and then the user
> > can configure the parameters of the feature based on the config id.
> >  So far the support is added for the over temperature and external
> > watchdog features.
> >
> > Added zynqmp_devinfo structure to handle muliple driver instances
> > when accessed by multiple devices.
> >
> > Signed-off-by: Ronak Jain <ronak.jain at xilinx.com>
> > ---
> > Changes in v3:
> > - Added zynqmp_devinfo structure to store device instances
> > - Modified feature_conf_id from atomic variable to u32
> > - Update commit message
> > - Resolved merge conflicts
> >
> > Changes in v2:
> > - Update commit message
> > ---
> >  drivers/firmware/xilinx/zynqmp.c | 93
> > ++++++++++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c
> > b/drivers/firmware/xilinx/zynqmp.c
> > index 6b05844e67d7..f37a8e805cd7 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -38,6 +38,16 @@
> >  static bool feature_check_enabled;
> >  static DEFINE_HASHTABLE(pm_api_features_map,
> > PM_API_FEATURE_CHECK_MAX_ORDER);
> >
> > +/**
> > + * struct zynqmp_devinfo - Structure for Zynqmp device instance
> > + * @dev:		Device Pointer
> > + * @feature_conf_id:	Feature conf id
> > + */
> > +struct zynqmp_devinfo {
> > +	struct device *dev;
> > +	u32 feature_conf_id;
> > +};
> > +
> >  /**
> >   * struct pm_api_feature_data - PM API Feature data
> >   * @pm_api_id:		PM API Id, used as key to index into hashmap
> > @@ -1424,6 +1434,78 @@ static DEVICE_ATTR_RW(pggs1);  static
> > DEVICE_ATTR_RW(pggs2);  static DEVICE_ATTR_RW(pggs3);
> >
> > +static ssize_t feature_config_id_show(struct device *device,
> > +				      struct device_attribute *attr,
> > +				      char *buf)
> > +{
> > +	struct zynqmp_devinfo *devinfo = dev_get_drvdata(device);
> > +
> > +	return sysfs_emit(buf, "%d\n", devinfo->feature_conf_id); }
> 
> You are adding new sysfs files without any Documentation/ABI/ entries :(
> 
> Please fix.
As you pointed out the documentation is already there. However, it needs to be updated. I will update it.
 
Thanks,
Ronak
> 
> thanks,
> 
> greg k-h