[PATCH] gpio: lpc32xx: Handle devm_gpiochip_add_data error codes
Jiasheng Jiang
jiasheng at iscas.ac.cn
Thu Dec 2 22:54:25 PST 2021
The return value of devm_gpiochip_add_data() is not always 0.
To catch the exception in case of the failure.
Fixes: 69c0a0a52cde ("gpio: lpc32xx: Use devm_gpiochip_add_data() for gpio registration")
Signed-off-by: Jiasheng Jiang <jiasheng at iscas.ac.cn>
---
drivers/gpio/gpio-lpc32xx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-lpc32xx.c b/drivers/gpio/gpio-lpc32xx.c
index 4e626c4235c2..4bda84b38cf5 100644
--- a/drivers/gpio/gpio-lpc32xx.c
+++ b/drivers/gpio/gpio-lpc32xx.c
@@ -518,8 +518,10 @@ static int lpc32xx_gpio_probe(struct platform_device *pdev)
lpc32xx_gpiochip[i].chip.of_node = pdev->dev.of_node;
lpc32xx_gpiochip[i].reg_base = reg_base;
}
- devm_gpiochip_add_data(&pdev->dev, &lpc32xx_gpiochip[i].chip,
+ int err = devm_gpiochip_add_data(&pdev->dev, &lpc32xx_gpiochip[i].chip,
&lpc32xx_gpiochip[i]);
+ if (err)
+ return err;
}
return 0;
--
2.25.1
More information about the linux-arm-kernel
mailing list