[PATCH] irqchip/apple-aic: Fix annotation

Hector Martin marcan at marcan.st
Wed Dec 1 21:23:36 PST 2021


Hi,

On 24/11/2021 01.16, Donghyeok Kim wrote:
> Annotate aic_init_smp() as __init
> 
> Signed-off-by: Donghyeok Kim <dthex5d at gmail.com>
> ---
>   drivers/irqchip/irq-apple-aic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 3759dc36cc8f..2543ef65825b 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
>   	.free = aic_ipi_free,
>   };
>   
> -static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> +static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
>   {
>   	struct irq_domain *ipi_domain;
>   	int base_ipi;
> 

This looks fine, but can you use a more descriptive commit message? 
Something like:

==
irqchip/apple-aic: Mark aic_init_smp() as __init

This function is only called from the driver init code.
==

Thanks,
-- 
Hector Martin (marcan at marcan.st)
Public Key: https://mrcn.st/pub



More information about the linux-arm-kernel mailing list