[PATCH 2/2] irqchip: nvic: Use GENERIC_IRQ_MULTI_HANDLER

Vladimir Murzin vladimir.murzin at arm.com
Wed Dec 1 05:43:01 PST 2021


On 12/1/21 12:30 PM, Arnd Bergmann wrote:
> On Wed, Dec 1, 2021 at 12:02 PM Vladimir Murzin <vladimir.murzin at arm.com> wrote:
>>
>> Rather then restructuring the ARMv7M entrly logic per TODO, just move
>> NVIC to GENERIC_IRQ_MULTI_HANDLER.
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin at arm.com>
> 
> Acked-by: Arnd Bergmann <arnd at arndb.de>
> 
> Thanks for finishing this one off as well! I don't know if you did this as a
> reaction to me doing the same for the three other platforms that don't
> use GENERIC_IRQ_MULTI_HANDLER yet[1], or if this was just a lucky
> coincidence. It sounds like this should be part of Ard's IRQ stack series
> as well then (adding him to Cc), as it fits in with my patches there.

It was reaction to Mark's TODO statement in his original submission [1].
I'd let maintainers to decide on the path it should land :) 

> 
> Would you mind also implementing and testing the missing bits
> for the stack switching on nommu irq entry, corresponding to [2] so
> we can just use that part unconditionally as well?

I can have a look but no promises since I have few issues with NOMMU
ATM (one of them seems to be cross-arch [2])

[1] https://lore.kernel.org/linux-arm-kernel/20211021180236.37428-10-mark.rutland@arm.com/
[2] https://lore.kernel.org/linux-mm/20211130172954.129587-1-vladimir.murzin@arm.com/T/

Cheers
Vladimir

> 
>        Arnd
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?h=arm-up-ti-in-task-v3&id=f3ad7675e9e02996331c69a48f45db60ac8e9852
> and parents
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/diff/arch/arm/kernel/entry-armv.S?h=arm-up-ti-in-task-v3&id=950bf934b1c1c4efe579f40a82a0fca0ae223d2a
> 



More information about the linux-arm-kernel mailing list