[PATCH] media: imx-pxp: Make use of the helper function devm_platform_ioremap_resource()

Philipp Zabel p.zabel at pengutronix.de
Tue Aug 31 23:46:38 PDT 2021


On Wed, 2021-09-01 at 13:51 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing at baidu.com>
> ---
>  drivers/media/platform/imx-pxp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c
> index 4321edc0c23d..723b096fedd1 100644
> --- a/drivers/media/platform/imx-pxp.c
> +++ b/drivers/media/platform/imx-pxp.c
> @@ -1636,7 +1636,6 @@ static int pxp_soft_reset(struct pxp_dev *dev)
>  static int pxp_probe(struct platform_device *pdev)
>  {
>  	struct pxp_dev *dev;
> -	struct resource *res;
>  	struct video_device *vfd;
>  	int irq;
>  	int ret;
> @@ -1652,8 +1651,7 @@ static int pxp_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dev->mmio = devm_ioremap_resource(&pdev->dev, res);
> +	dev->mmio = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(dev->mmio))
>  		return PTR_ERR(dev->mmio);

Reviewed-by: Philipp Zabel <p.zabel at pengutronix.de>

regards
Philipp



More information about the linux-arm-kernel mailing list