[PATCH v11 3/4] pinctrl: mediatek: mt8195: Add pm_ops

zhiyong.tao zhiyong.tao at mediatek.com
Tue Aug 31 02:11:38 PDT 2021


On Tue, 2021-08-31 at 15:53 +0800, Chen-Yu Tsai wrote:
> On Mon, Aug 30, 2021 at 8:37 AM Zhiyong Tao <zhiyong.tao at mediatek.com> wrote:
> >
> > Setting this up will configure wake from suspend properly,
> > and wake only for the interrupts that are setup in wake_mask,
> > not all interrupts.
> 
> This sounds like a fix. Please add a Fixes tag for this patch. This makes
> tracking things easier.
> 
> So,
> 
> Fixes: 6cf5e9ef362a ("pinctrl: add pinctrl driver on mt8195")
> Reviewed-by: Chen-Yu Tsai <wenst at chromium.org>
> 
> Also this patch is unrelated to the rest. You should send it separately.
> This would also help the maintainer merge it directly.
> 

Hi Chen-Yu,

We will add Fixed tag for this patch and send it separately.

Thanks.

> > Signed-off-by: Zhiyong Tao <zhiyong.tao at mediatek.com>
> > ---
> >  drivers/pinctrl/mediatek/pinctrl-mt8195.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8195.c b/drivers/pinctrl/mediatek/pinctrl-mt8195.c
> > index a7500e18bb1d..892e79703f98 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mt8195.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8195.c
> > @@ -839,6 +839,7 @@ static struct platform_driver mt8195_pinctrl_driver = {
> >         .driver = {
> >                 .name = "mt8195-pinctrl",
> >                 .of_match_table = mt8195_pinctrl_of_match,
> > +               .pm = &mtk_paris_pinctrl_pm_ops,
> >         },
> >         .probe = mt8195_pinctrl_probe,
> >  };
> > --
> > 2.18.0
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek



More information about the linux-arm-kernel mailing list