[PATCH linux-next] firmware/psci: fix application of sizeof to pointer
Mark Rutland
mark.rutland at arm.com
Tue Aug 24 03:58:24 PDT 2021
On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote:
> sizeof when applied to a pointer typed expression gives the size of
> the pointer.
>
> ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang at zte.com.cn>
>From looking at the git history, we should add:
Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)"
With that:
Acked-by: Mark Rutland <mark.rutland at arm.com>
Lorenzo, how do we normally direct these patches?
Thanks,
Mark.
> ---
> drivers/firmware/psci/psci_checker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c
> index 9a369a2..116eb46 100644
> --- a/drivers/firmware/psci/psci_checker.c
> +++ b/drivers/firmware/psci/psci_checker.c
> @@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
> if (!alloc_cpumask_var(&tmp, GFP_KERNEL))
> return -ENOMEM;
>
> - cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups),
> + cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups),
> GFP_KERNEL);
> if (!cpu_groups) {
> free_cpumask_var(tmp);
> --
> 1.8.3.1
>
>
More information about the linux-arm-kernel
mailing list