[PATCH] kselftest/arm64: pac: Fix skipping of tests on systems without PAC

Mark Brown broonie at kernel.org
Fri Aug 20 03:55:31 PDT 2021


On Fri, Aug 20, 2021 at 12:39:39PM +0530, Amit Kachhap wrote:
> On 8/19/21 10:27 PM, Mark Brown wrote:

> > -	ASSERT_NE(0, hwcaps & HWCAP_PACA) TH_LOG("PAUTH not enabled"); \
> > +	if (!(hwcaps & HWCAP_PACA))					\
> > +		SKIP(return, "PAUTH not enabled"); \
> >   } while (0)
> >   #define ASSERT_GENERIC_PAUTH_ENABLED() \

> May be ASSERT_GENERIC_PAUTH_ENABLED can be replaced with
> something like VERIFY_GENERIC_PAUTH_ENABLED

I thought briefly about bikeshedding the name but didn't come up with
anything that was sufficiently better/clearer.

> or can be modified like below and instead of failing it skips with a
> message

>   -	ASSERT_NE(0, hwcaps & HWCAP_PACA) TH_LOG("PAUTH not enabled"); \
>   +	ASSERT_NE(0, hwcaps & HWCAP_PACA) SKIP(return, "PAUTH not enabled");

That's what the patch does?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20210820/157054ed/attachment.sig>


More information about the linux-arm-kernel mailing list