[PATCH net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge

Vladimir Oltean vladimir.oltean at nxp.com
Tue Aug 10 01:16:17 PDT 2021


Hi Leon,

On Tue, Aug 10, 2021 at 09:50:41AM +0300, Leon Romanovsky wrote:
> > +	memset(&send_info, 0, sizeof(send_info));
> 
> This can be written simpler.
> struct switchdev_notifier_fdb_info send_info = {};
> 
> In all places.

Because the structure contains a sub-structure, I believe that a
compound literal initializer would require additional braces for the
initialization of its sub-objects too. At least I know that expressions
like that have attracted the attention of clang people in the past:
https://patchwork.ozlabs.org/project/netdev/patch/20190506202447.30907-1-natechancellor@gmail.com/
So I went for the 'unambiguous' path.


More information about the linux-arm-kernel mailing list