[PATCH v2] cpufreq: arm_scmi: Fix error path when allocation failed

Lukasz Luba lukasz.luba at arm.com
Wed Aug 4 03:51:56 PDT 2021



On 8/4/21 5:02 AM, Viresh Kumar wrote:
> On 03-08-21, 10:07, Lukasz Luba wrote:
>> Stop the initialization when cpumask allocation failed and return an
>> error.
>>
>> Fixes: 80a064dbd556 ("scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM")
>> Signed-off-by: Lukasz Luba <lukasz.luba at arm.com>
>> ---
>> changes:
>> v2:
>> - removed dev_warn() since it's not needed in this case
>> - adjusted the patch description
>>
>>   drivers/cpufreq/scmi-cpufreq.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
>> index ec9a87ca2dbb..75f818d04b48 100644
>> --- a/drivers/cpufreq/scmi-cpufreq.c
>> +++ b/drivers/cpufreq/scmi-cpufreq.c
>> @@ -134,7 +134,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
>>   	}
>>   
>>   	if (!zalloc_cpumask_var(&opp_shared_cpus, GFP_KERNEL))
>> -		ret = -ENOMEM;
>> +		return -ENOMEM;
>>   
>>   	/* Obtain CPUs that share SCMI performance controls */
>>   	ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus);
> 
> Applied. Thanks.
> 

Thank you for taking it.



More information about the linux-arm-kernel mailing list