[PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset

Oliver Upton oupton at google.com
Wed Aug 4 03:22:26 PDT 2021


On Wed, Aug 4, 2021 at 3:17 AM Andrew Jones <drjones at redhat.com> wrote:
> > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c
> > index a8815b09da3e..f15058612994 100644
> > --- a/arch/arm64/kvm/arch_timer.c
> > +++ b/arch/arm64/kvm/arch_timer.c
> > @@ -85,11 +85,15 @@ u64 timer_get_cval(struct arch_timer_context *ctxt)
> >  static u64 timer_get_offset(struct arch_timer_context *ctxt)
> >  {
> >       struct kvm_vcpu *vcpu = ctxt->vcpu;
> > +     struct arch_timer_cpu *timer = vcpu_timer(vcpu);
>
> This new timer variable doesn't appear to get used.

Ooops, this is stale. Thanks for catching that.

>
> Reviewed-by: Andrew Jones <drjones at redhat.com>
>

Thanks for the quick review!

--
Oliver



More information about the linux-arm-kernel mailing list