[PATCH] pwm: sun4i: Round delay time up to a nearest jiffy

Roman Beranek roman.beranek at prusa3d.cz
Fri Apr 30 16:10:03 BST 2021


Hello Uwe,

On Fri Apr 30, 2021 at 11:51 AM CEST, Uwe Kleine-König wrote:
> If you agree that dropping both delay and clk_disable completely is the
> right thing, you address both problems and going forward with your patch
> isn't sensible.

I had my doubts whether simply clearing the PWMx_EN bit would be enough
to turn the PWM off but I stand corrected. It does work.

The added bonusu is that once without the invocations of {u,m}sleep and
clk_{enable_,disable_un}prepare, the sun4i_pwm_apply function finally
becomes safe for running in an atomic context.

I will therefore prepare a new patch and come back some time next week.

Have a great weekend,
Roman



More information about the linux-arm-kernel mailing list