Aw: Re: [PATCH] thermal: mediatek: add sensors-support
Daniel Lezcano
daniel.lezcano at linaro.org
Tue Apr 20 16:18:32 BST 2021
Hi Frank,
On 20/04/2021 16:59, Frank Wunderlich wrote:
> Hi,
>
>> Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr
>> Von: "Daniel Lezcano" <daniel.lezcano at linaro.org>
>
>> No #ifdef in C file.
> ...
>
>> devm_thermal_add_hwmon_sysfs() ?
>
> based on your comments this should be enough/right?
>
> #if IS_ENABLED(CONFIG_THERMAL_HWMON)
> tzdev->tzp->no_hwmon = false;> ret = devm_thermal_add_hwmon_sysfs(tzdev);
> if (ret)
> dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> #endif
>
> if yes i send out v2, at least it works on my device
just the following lines should work:
ret = devm_thermal_add_hwmon_sysfs(tzdev);
if (ret)
dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
The no_hwmon usage is a bit fuzzy in the thermal core code.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
More information about the linux-arm-kernel
mailing list