[PATCH -next] i2c: imx: Fix PM reference leak in i2c_imx_reg_slave()

Wolfram Sang wsa at kernel.org
Wed Apr 14 09:04:12 BST 2021


On Thu, Apr 08, 2021 at 07:06:38PM +0800, Ye Weihua wrote:
> The PM reference count is not expected to be incremented on return in
> these functions.
> 
> However, pm_runtime_get_sync() will increment the PM reference count
> even on failure. forgetting to put the reference again will result in
> a leak.
> 
> Replace it with pm_runtime_resume_and_get() to keep the usage counter
> balanced.
> 
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Ye Weihua <yeweihua4 at huawei.com>

After rebasing, only one hunk was left:

> @@ -801,7 +801,7 @@ static int i2c_imx_reg_slave(struct i2c_client *client)
>  	i2c_imx->last_slave_event = I2C_SLAVE_STOP;
>  
>  	/* Resume */
> -	ret = pm_runtime_get_sync(i2c_imx->adapter.dev.parent);
> +	ret = pm_runtime_resume_and_get(i2c_imx->adapter.dev.parent);
>  	if (ret < 0) {
>  		dev_err(&i2c_imx->adapter.dev, "failed to resume i2c controller");
>  		return ret;

I applied this to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20210414/d30268a0/attachment.sig>


More information about the linux-arm-kernel mailing list