[PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support
Nobuhiro Iwamatsu
nobuhiro1.iwamatsu at toshiba.co.jp
Mon Apr 12 04:04:58 BST 2021
Hi,
On Sat, Apr 10, 2021 at 08:52:22PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> one more comment:
>
> On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote:
> > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_chip *chip)
>
> all functions but this one start have the common prefix "visconti_pwm_".
> I like the concept of a common prefix and so you could rename this
> function to visconti_pwm_from_chip or similar.
OK, I will change.
>
> Best regards
> Uwe
>
Best regards,
Nobuhiro
More information about the linux-arm-kernel
mailing list