[PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok

[Marc Zyngier]

On Sat, 10 Apr 2021 20:58:22 +0100,
Edmundo Carmona Antoranz <eantoranz at gmail.com> wrote:
> 
> On Sat, Apr 10, 2021 at 1:03 PM Marc Zyngier <maz at kernel.org> wrote:
> >
> > Hi Edmundo,
> 
> Sup!
> 
> >
> >
> > No difference? Have you simply tried removing the macro and witness
> > the effect? If it made no difference, why have the macro at all then?
> 
> Oh, come on! so having the macro defined so that you can do things like
> 
> lib/vdso/gettimeofday.c:34:#ifndef vdso_clocksource_ok
> 
> counts as "a difference" to you? XD ok ok ... so, I have deleted
> "extended linux kernel C preprocessor knowledge" from my linkedin
> profile.

If you want to look cool on Linkedin, the C preprocessor really is the
wrong thing to boast about. Consider adding things like iron oxide,
which will definitely boost your visibility.

> I can safely assume that this is a big resounding NACK, right? :-D

Not necessarily a NAK, because I don't like doing that. But I find
this an unnecessarily change and a fairly pointless divergence from an
established practice. Others may agree with you.

But it was worth pointing out that "it actually makes no difference to
have the macro defined or not" wasn't quite the right thing to put in
the commit message.

>
> >
> > Also, run this, for example:
> >
> > git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }'
> >
> > Are you going to "fix" these too?
> >
> > Thanks,
> 
> Thank you for the lesson, man. Still have a lot of stuff to learn in
> front of me.

We all do.

	M.

-- 
Without deviation from the norm, progress is not possible.