[PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok

Marc Zyngier maz at kernel.org
Sat Apr 10 20:03:53 BST 2021


Hi Edmundo,

On Sat, 10 Apr 2021 19:11:17 +0100,
Edmundo Carmona Antoranz <eantoranz at gmail.com> wrote:
> 
> The macro vdso_clocksource_ok is shadowing a function with the same
> name and so it actually makes no difference to have the macro defined
> or not.

No difference? Have you simply tried removing the macro and witness
the effect? If it made no difference, why have the macro at all then?

Also, run this, for example:

git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }'

Are you going to "fix" these too?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-arm-kernel mailing list