New 'make dtbs_check W=1' warnings

Thu Apr 8 16:08:26 BST 2021

Greetings to all Arm platform maintainers,

I've just gone through the DT merges I've received so far and, with a
little help from Rob,
managed to run 'make dtbs_check W=1' before and after, to see what
warnings we get.
The good news is that the number of warnings is going down, but
unfortunately there
is still an unmanageable amount of remaining warnings, and some new
ones crept in.

I'm still working on my tooling for this, to catch these better, but
ideally I think we should
try to not introduce new warnings. I think some platforms are already
clean, and I did
not see any new warnings for mvebu, samsung and broadcom. There were a lot of
warnings from .dtsi files, and I probably did an incomplete job at
deduplicating those.

See below for the other platforms, and the new warnings that I found.
If these are
valid, please send a fixup before the merge window, and let me know if
you have ideas
for how we should handle these in the future.

For this merge window, I don't think any of them are show-stoppers (Rob, let me
know if you disagree), but in the long run we may want to gradually enforce
a rule about not merging changes that introduce any new warnings, in order to
have a chance of cleaning up the existing ones.

       Arnd

arch/arm/boot/dts/ste-href520-tvk.dt.yaml: accelerometer at 19:
interrupts: [[18, 1], [19, 1]] is too long
arch/arm/boot/dts/ste-hrefprev60-tvk.dt.yaml: gyroscope at 68:
interrupts-extended: [[22, 0, 1], [21, 31, 1]] is too long
arch/arm/boot/dts/ste-hrefv60plus-tvk.dt.yaml: gyroscope at 68:
interrupts-extended: [[25, 0, 1], [24, 31, 1]] is too long
arch/arm/boot/dts/ste-hrefv60plus-tvk.dt.yaml: accelerometer at 1c:
interrupts: [[18, 1], [19, 1]] is too long

arch/arm/boot/dts/omap5-cm-t54.dt.yaml: gpmc at 50000000: 'clocks' is a
dependency of 'clock-names'
arch/arm/boot/dts/omap5-igep0050.dt.yaml: gpmc at 50000000: 'clocks' is a
dependency of 'clock-names'
arch/arm/boot/dts/omap5-sbc-t54.dt.yaml: gpmc at 50000000: 'clocks' is a
dependency of 'clock-names'
arch/arm/boot/dts/omap5-uevm.dt.yaml: gpmc at 50000000: 'clocks' is a
dependency of 'clock-names'

arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dt.yaml:
pin-controller at 50002000: 'ltdc' does not match any of the regexes:
'-[0-9]*$', '^gpio@[0-9a-f]*$', 'pinctrl-[0-9]+'

arch/arm/boot/dts/at91-sama5d2_ptc_ek.dt.yaml: /: 'etm at 73C000' does
not match any of the regexes: '@(0|[1-9a-f][0-9a-f]*)$', '^[^@]+$',
'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dt.yaml: /: 'etm at 73C000' does not
match any of the regexes: '@(0|[1-9a-f][0-9a-f]*)$', '^[^@]+$',
'pinctrl-[0-9]+'

amlogic/meson-gxl-s905d-mecool-kii-pro.dts:31.19-42.4: Warning
(avoid_unnecessary_addr_size): /gpio-keys-polled: unnecessary
#address-cells/#size-cells without "ranges" or child "reg" property
amlogic/meson-gxl-s905d-mecool-kii-pro.dts:37.12-41.5: Warning
(unit_address_vs_reg): /gpio-keys-polled/button at 0: node has a unit
name, but no reg or ranges property
amlogic/meson-gxm-mecool-kiii-pro.dts:36.19-47.4: Warning
(avoid_unnecessary_addr_size): /gpio-keys-polled: unnecessary
#address-cells/#size-cells without "ranges" or child "reg" property
amlogic/meson-gxm-mecool-kiii-pro.dts:42.12-46.5: Warning
(unit_address_vs_reg): /gpio-keys-polled/button at 0: node has a unit
name, but no reg or ranges property
amlogic/meson-gxm-minix-neo-u9h.dts:42.19-53.4: Warning
(avoid_unnecessary_addr_size): /gpio-keys-polled: unnecessary
#address-cells/#size-cells without "ranges" or child "reg" property
amlogic/meson-gxm-minix-neo-u9h.dts:48.12-52.5: Warning
(unit_address_vs_reg): /gpio-keys-polled/button at 0: node has a unit
name, but no reg or ranges property
amlogic/meson-gxl-s805x-p241.dt.yaml: serial at 84c0: 'uart-has-rtscts'
does not match any of the regexes: 'pinctrl-[0-9]+'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: audio-controller at 5400:
'sound-name-prefix' does not match any of the regexes:
'pinctrl-[0-9]+'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml:
audio-controller at c8832000: 'AVDD-supply', 'sound-name-prefix' do not
match any f the regexes: 'pinctrl-[0-9]+'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: bluetooth:
clock-names: ['lpo'] is too short
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: bluetooth:
clock-names:0: 'txco' was expected
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: bluetooth: clocks:
[[23]] is too short
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: bus at c8834000:
eth-phy-mux: {'type': 'object'} is not allowed for {'compatible':
['mdio-mux-mmioreg', 'mdio-mux'], '#address-cells': [[1]],
'#size-cells': [[0]], 'reg': [[0, 1372, 0, 4]], 'mux-mask':
[[4294967295]], 'mdio-parent-bus': [[35]], 'mdio at e40908ff': {'reg':
[[3825797375]], '#address-cells': [[1]], '#size-cells': [[0]],
'ethernet-phy at 8': {'compatible': ['ethernet-phy-id0181.4400'],
'interrupts': [[0, 9, 4]], 'reg': [[8]], 'max-speed': [[100]],
'phandle': [[36]]}}, 'mdio at 2009087f': {'reg': [[537462911]],
'#address-cells': [[1]], '#size-cells': [[0]]}}
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: bus at c8834000: rng:
{'type': 'object'} is not allowed for {'compatible':
['amlogic,meson-rng'], 'reg': [[0, 0, 0, 4]], 'clocks': [[3, 25]],
'clock-names': ['core']}
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: hdmi-tx at c883a000:
'sound-name-prefix' does not match any of the regexes: pinctrl-[0-9]+'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: ir at 580:
linux,rc-map-name:0: 'rc-mecool-kii-pro' is not one of
['rc-adstech-dvb-t-ci', 'rc-alink-dtu-m', 'rc-anysee',
'rc-apac-viewcomp',..., 'rc-zx-irdec']
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: leds: 'blue' does not
match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: serial at 84c0:
'bluetooth', 'uart-has-rtscts' do not match any of the regexes:
'pinctrl-0-9]+'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound:
'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do
not atch any of the regexes: '^dai-link-[0-9]+$', 'pinctrl-[0-9]+'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound: 'clocks' is a
dependency of 'assigned-clocks'
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound: audio-routing:
['AU2 INL', 'ACODEC LOLP', 'AU2 INR', 'ACODEC LORP', AU2 INL', 'ACODEC
LOLN', 'AU2 INR', 'ACODEC LORN', 'Lineout', 'AU2 OUTL', 'Lineout',
'AU2 OUTR'] is too long
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound:
dai-link-0:sound-dai:0: [63, 0, 0] is too long
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound:
dai-link-0:sound-dai:0:1: missing phandle tag in 0
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound:
dai-link-0:sound-dai:0:2: missing phandle tag in 0
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound:
dai-link-1:sound-dai:0: [63, 0, 1] is too long
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound:
dai-link-1:sound-dai:0:1: missing phandle tag in 0
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: sound:
dai-link-1:sound-dai:0:2: missing phandle tag in 1
amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml: vpu at d0100000:
'amlogic,canvas' does not match any of the regexes: 'pinctrl-[0-9]+'

freescale/imx8-ss-audio.dtsi:16.33-21.4: Warning (simple_bus_reg):
/bus at 59000000/clock-audio-ipg: missing or empty reg/ranges property
freescale/imx8-ss-conn.dtsi:16.31-21.4: Warning (simple_bus_reg):
/bus at 5b000000/clock-conn-axi: missing or empty reg/ranges property
freescale/imx8-ss-conn.dtsi:23.31-28.4: Warning (simple_bus_reg):
/bus at 5b000000/clock-conn-ahb: missing or empty reg/ranges property
freescale/imx8-ss-conn.dtsi:30.31-35.4: Warning (simple_bus_reg):
/bus at 5b000000/clock-conn-ipg: missing or empty reg/ranges property
freescale/imx8-ss-dma.dtsi:16.29-21.4: Warning (simple_bus_reg):
/bus at 5a000000/clock-dma-ipg: missing or empty reg/ranges property
freescale/imx8-ss-lsio.dtsi:16.31-21.4: Warning (simple_bus_reg):
/bus at 5d000000/clock-lsio-mem: missing or empty reg/ranges property
freescale/imx8-ss-lsio.dtsi:23.31-28.4: Warning (simple_bus_reg):
/bus at 5d000000/clock-lsio-bus: missing or empty reg/ranges property
freescale/fsl-lx2160a-clearfog-cx.dt.yaml: ethernet at 7: 'sfp' does not
match any of the regexes: 'pinctrl-[0-9]+'
freescale/fsl-lx2160a-clearfog-cx.dt.yaml: ethernet at 8: 'sfp' does not
match any of the regexes: 'pinctrl-[0-9]+'
freescale/fsl-lx2160a-clearfog-cx.dt.yaml: ethernet at 9: 'sfp' does not
match any of the regexes: 'pinctrl-[0-9]+'
freescale/fsl-lx2160a-clearfog-cx.dt.yaml: ethernet at a: 'sfp' does not
match any of the regexes: 'pinctrl-[0-9]+'
freescale/fsl-lx2160a-honeycomb.dt.yaml: power-controller at 1e34040:
'#power-domain-cells' is a required property

mediatek/mt8183-pumpkin.dts:35.36-39.5: Warning (unit_address_vs_reg):
/reserved-memory/scp_mem_region: node has a reg or ranges property,
but no unit name
mediatek/mt8183-pumpkin.dts:58.8-64.4: Warning (unit_address_vs_reg):
/ntc at 0: node has a unit name, but no reg or ranges property
mediatek/mt8183.dtsi:1106.26-1112.6: Warning (unit_address_format):
/soc/t-phy at 11f40000/usb-phy at 0700: unit name should not have leading 0s
mediatek/mt8183.dtsi:1234.22-1246.5: Warning
(avoid_unnecessary_addr_size): /soc/dsi at 14014000: unnecessary
#address-cells/#size-cells without "ranges" or child "reg" property
mediatek/mt8183.dtsi:676.17-795.5: Warning (simple_bus_reg):
/soc/thermal-zones: missing or empty reg/ranges property
mediatek/mt8183.dtsi:684.30-688.8: Warning (unit_address_vs_reg):
/soc/thermal-zones/cpu_thermal/trips/trip-point at 0: node has a unit
name, but no reg or ranges property
mediatek/mt8183-evb.dt.yaml: soc: thermal-zones: {'type': 'object'} is
not allowed for {'cpu_thermal': {'polling-delay-passive': [[100]],
'polling-delay': [[500]], 'thermal-sensors': [[41, 0]...
'pinctrl-[0-9]+'
mediatek/mt8183-kukui-jacuzzi-damu.dt.yaml: anx7625 at 58:
'#address-cells', '#size-cells', 'panel_flags', 'port at 0', 'port at 1' do
not match any of the regexes: 'pinctrl-[0-9]+'
mediatek/mt8183-kukui-jacuzzi-damu.dt.yaml: anx7625 at 58: 'ports' is a
required property
mediatek/mt8183-kukui-jacuzzi-damu.dt.yaml: cros_ec: 'mtk,rpmsg-name'
does not match any of the regexes: '^#.*', ...

qcom/sc7180.dtsi:1204.21-1220.6: Warning
(avoid_unnecessary_addr_size): /soc at 0/geniqup at ac0000/i2c at a8c000:
unnecessary #address-cells/#size-cells without "ranges" or child "reg"
property
qcom/sc7180.dtsi:965.21-981.6: Warning (avoid_unnecessary_addr_size):
/soc at 0/geniqup at 8c0000/i2c at 890000: unnecessary
#address-cells/#size-cells without "ranges" or child "reg" property
qcom/sdm845.dtsi:3912.23-4045.5: Warning (simple_bus_reg):
/soc at 0/camss at a00000: simple-bus unit address format error, expected
"acb3000"
qcom/sdm845.dtsi:4041.10-4044.6: Warning (graph_child_address):
/soc at 0/camss at a00000/ports: graph node has single child node 'port at 0',
#address-cells/#size-cells are not necessary
qcom/sdm845.dtsi:4102.32-4129.5: Warning (simple_bus_reg):
/soc at 0/dsi-opp-table: missing or empty reg/ranges property
ti/k3-am64-main.dtsi:376.40-385.4: Warning (simple_bus_reg):
/bus at f4000/interrupt-controller0: missing or empty reg/ranges property
ti/k3-am64-main.dtsi:45.13-135.4: Warning (simple_bus_reg):
/bus at f4000/dmss: missing or empty reg/ranges property
ti/k3-am64-mcu.dtsi:77.39-86.4: Warning (simple_bus_reg):
/bus at f4000/bus at 4000000/interrupt-controller1: missing or empty
reg/ranges property
qcom/msm8916-samsung-a5u-eur.dt.yaml: spmi at 200f000: reg: [[33615872,
4096], [37748736, 4194304], [46137344, 4194304], [58720256, 2097152],
[33595392, 8448]] is too long
qcom/sc7180-trogdor-lazor-r0.dt.yaml: gmu at 506a000: compatible:0:
'qcom,adreno-gmu-618.0' is not one of ['qcom,adreno-gmu-630.2']
qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml: memory at 80900000:
'device_type' is a required property
qcom/sdm850-lenovo-yoga-c630.dt.yaml: memory at 97b00000: 'device_type'
is a required property

renesas/r8a774a1-beacon-rzg2m-kit.dt.yaml: csi2 at feaa0000: ports:
'port at 0' is a required property
renesas/r8a779a0-falcon.dt.yaml: thermal-zones: 'sensor-thermal1',
'sensor-thermal2', 'sensor-thermal3', 'sensor-thermal4',
'sensor-thermal5' do not match any of the regexes:
'^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
renesas/r8a779a0-falcon.dt.yaml: timer at e61e0000: compatible:0:
'renesas,tmu-r8a779a0' is not one of ['renesas,tmu-r8a7740',
'renesas,tmu-r8a774a1', 'renesas,tmu-r8a774b1',
'renesas,tmu-r8a774c0', 'renesas,tmu-r8a774e1', 'renesas,tmu-r8a7778',
'renesas,tmu-r8a7779', 'renesas,tmu-r8a7795', 'renesas,tmu-r8a7796',
'renesas,tmu-r8a77961', 'renesas,tmu-r8a77965',
'renesas,tmu-r8a77970', 'renesas,tmu-r8a77980',
'renesas,tmu-r8a77990', 'renesas,tmu-r8a77995']

rockchip/rk3399-khadas-edge-v.dt.yaml: usb at fe800000:
#address-cells:0:0: 1 was expected

ti/k3-am642-evm.dt.yaml: bus at 4000000: interrupt-controller1: {'type':
'object'} is not allowed for {'compatible': ['ti,sci-intr'],
'ti,intr-trigger-type': [[1]], 'interrupt-controller': True,
'interrupt-parent': [[1]], '#interrupt-cells': [[1]], 'ti,sci': [[4]],
'ti,sci-dev-id': [[5]], 'ti,interrupt-ranges': [[0, 104, 4]],
'phandle': [[5]]}
ti/k3-am642-evm.dt.yaml: bus at f4000: dmss: {'type': 'object'} is not
allowed for {'compatible': ['simple-mfd'], '#address-cells': [[2]],
'#size-cells': [[2]], 'dma-ranges': True, 'ranges':  'phandle':
[[7]]}}
ti/k3-am642-evm.dt.yaml: bus at f4000: interrupt-controller0: {'type':
'object'} is not allowed for {'compatible': ['ti,sci-intr'],
'ti,intr-trigger-type': [[1]], 'interrupt-controller': True,
'interrupt-parent': [[1]], '#interrupt-cells': [[1]], 'ti,sci': [[4]],
'ti,sci-dev-id': [[3]], 'ti,interrupt-ranges': [[0, 32, 16]],
'phandle': [[15]]}
ti/k3-am642-evm.dt.yaml: flash at 0: 'cdns,read-delay', 'cdns,tchsh-ns',
'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not match any of
the regexes: '^partition@', 'pinctrl-[0-9]+'
ti/k3-am642-sk.dt.yaml: bus at 4000000: interrupt-controller1: {'type':
'object'} is not allowed for {'compatible': ['ti,sci-intr'],
'ti,intr-trigger-type': [[1]], ...
ti/k3-am642-sk.dt.yaml: bus at f4000: dmss: {'type': 'object'} is not
allowed for {'compatible': ['simple-mfd'], ...
ti/k3-am642-sk.dt.yaml: bus at f4000: interrupt-controller0: {'type':
'object'} is not allowed for {'compatible': ['ti,sci-intr'],
'ti,intr-trigger-type': [[1]], 'interrupt-controller': True,
'interrupt-parent': [[1]], '#interrupt-cells': [[1]], 'ti,sci': [[4]],
'ti,sci-dev-id': [[3]], 'ti,interrupt-ranges': [[0, 32, 16]],
'phandle': [[11]]}
ti/k3-am642-sk.dt.yaml: flash at 0: 'cdns,read-delay', 'cdns,tchsh-ns',
'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do not match any of
the regexes: '^partition@', 'pinctrl-[0-9]+'
ti/k3-j7200-common-proc-board.dt.yaml: flash at 0: 'cdns,read-delay',
'cdns,tchsh-ns', 'cdns,tsd2d-ns', 'cdns,tshsl-ns', 'cdns,tslch-ns' do
not match any of the regexes: '^partition@', 'pinctrl-[0-9]+'