[PATCH] irqchip/wpcm450: Drop COMPILE_TEST

Marc Zyngier maz at kernel.org
Thu Apr 8 11:43:19 BST 2021


On 2021-04-08 09:45, Jonathan Neuschäfer wrote:
> On Thu, Apr 08, 2021 at 09:00:30AM +0100, Marc Zyngier wrote:
>> This driver is (for now) ARM specific, and currently doesn't
>> build with a variety of architectures (ia64, RISC-V, x86_64
>> at the very least).
>> 
>> Drop COMPILE_TEST from Kconfig until it gets sorted out.
>> 
>> Cc: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
>> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
>> Signed-off-by: Marc Zyngier <maz at kernel.org>
>> ---
> 
> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>

Thanks for that.

> 
>>  drivers/irqchip/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 38ad9dcf42c3..715eb4366e35 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -579,7 +579,7 @@ config MST_IRQ
>> 
>>  config WPCM450_AIC
>>  	bool "Nuvoton WPCM450 Advanced Interrupt Controller"
>> -	depends on ARCH_WPCM450 || COMPILE_TEST
>> +	depends on ARCH_WPCM450
> 
> I guess I could use (COMPILE_TEST && ARM) or something…

One of the major interest of COMPILE_TEST to be able to check code
cross-architecture. For code that cannot compile cross-architecture,
I'm not sure it matters much.

We can achieve the same result by enabling multi-platform builds (and
this system should probably end-up in multi_v5_defconfig).

         M.
-- 
Jazz is not dead. It just smells funny...



More information about the linux-arm-kernel mailing list