[PATCH 2/4] coresight: etm: perf: Make symbol 'format_attr_contextid' static
Mathieu Poirier
mathieu.poirier at linaro.org
Wed Apr 7 17:00:05 BST 2021
From: Wei Yongjun <weiyongjun1 at huawei.com>
The sparse tool complains as follows:
drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning:
symbol 'format_attr_contextid' was not declared. Should it be static?
This symbol is not used outside of coresight-etm-perf.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci at huawei.com>
Link: https://lore.kernel.org/r/20210308123250.2417947-1-weiyongjun1@huawei.com
Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose at arm.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 0f603b4094f2..bdbb77334329 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
return sprintf(page, "config:%d\n", pid_fmt);
}
-struct device_attribute format_attr_contextid =
+static struct device_attribute format_attr_contextid =
__ATTR(contextid, 0444, format_attr_contextid_show, NULL);
static struct attribute *etm_config_formats_attr[] = {
--
2.25.1
More information about the linux-arm-kernel
mailing list