[PATCH v4 11/18] asm-generic/io.h: implement pci_remap_cfgspace using ioremap_np

Andy Shevchenko andy.shevchenko at gmail.com
Wed Apr 7 14:27:42 BST 2021


On Fri, Apr 2, 2021 at 12:07 PM Hector Martin <marcan at marcan.st> wrote:
>
> Now that we have ioremap_np(), we can make pci_remap_cfgspace() default
> to it, falling back to ioremap() on platforms where it is not available.
>
> Remove the arm64 implementation, since that is now redundant. Future
> cleanups should be able to do the same for other arches, and eventually
> make the generic pci_remap_cfgspace() unconditional.

...

> +       void __iomem *ret = ioremap_np(offset, size);
> +
> +       if (!ret)
> +               ret = ioremap(offset, size);
> +
> +       return ret;

Usually negative conditions are worse for cognitive functions of human beings.
(On top of that some patterns are applied)

I would rewrite above as

void __iomem *ret;

ret = ioremap_np(offset, size);
if (ret)
  return ret;

return ioremap(offset, size);

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list