[PATCH V2] drm/bridge: lvds-codec: Add support for pixel data sampling edge select
Marek Vasut
marex at denx.de
Wed Apr 7 10:55:56 BST 2021
On 3/22/21 11:29 AM, Marek Vasut wrote:
> On 3/22/21 2:14 AM, Laurent Pinchart wrote:
>> Hi Marek,
>
> Hi,
>
> [...]
>
>>> diff --git
>>> a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
>>> b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
>>> index e5e3c72630cf..399a6528780a 100644
>>> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
>>> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
>>> @@ -74,6 +74,13 @@ properties:
>>> additionalProperties: false
>>> + pixelclk-active:
>>> + description: |
>>> + Data sampling on rising or falling edge.
>>> + Use 0 to sample pixel data on rising edge and
>>> + Use 1 to sample pixel data on falling edge and
>>> + enum: [0, 1]
>>
>> The idea is good, but instead of adding a custom property, how about
>> reusing the pclk-sample property defined in
>> ../../media/video-interfaces.yaml ?
>
> Repeating myself from V1 discussion ... Either is fine by me, but I
> think pixelclk-active, which comes from panel-timings.yaml is closer to
> the video than multimedia bindings.
Was there ever any reply from Rob on this ?
More information about the linux-arm-kernel
mailing list