[PATCH] arm64: Make CONFIG_CMDLINE behavior configurable

Catalin Marinas catalin.marinas at arm.com
Tue Sep 29 13:43:47 EDT 2020


On Tue, Sep 29, 2020 at 10:46:09AM +0200, Matija Glavinic Pecotic wrote:
> arm64 has no means to define behavior if CONFIG_CMDLINE is set as e.g.
> arm32 has. Parts of the kernel will ignore CMDLINE if behavior on how
> to treat is not specified, e.g.:
> 
> drivers/of/fdt.c:early_init_dt_scan_chosen:
>   #ifdef CONFIG_CMDLINE
>   #if defined(CONFIG_CMDLINE_EXTEND)
>         strlcat(data, " ", COMMAND_LINE_SIZE);
>         strlcat(data, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
>   #elif defined(CONFIG_CMDLINE_FORCE)
>         strlcpy(data, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
>   #else
>         /* No arguments from boot loader, use kernel's  cmdl*/
>         if (!((char *)data)[0])
>                 strlcpy(data, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
>   #endif
>   #endif /* CONFIG_CMDLINE */
> 
> Sync behavior of arm64 with arm32 (and other platforms).

I think this came up in the past and was rejected. What is the use-case
for all these combinations? Can you not fix the boot-loader? Sync'ing
the arm64 and arm32 behaviour is not a goal, we try to get away from
some old habits.

-- 
Catalin



More information about the linux-arm-kernel mailing list