[PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up

Robin Gong yibin.gong at nxp.com
Mon Sep 28 04:06:10 EDT 2020


On 2020/09/28 1:00 Krzysztof Kozlowski <krzk at kernel.org> wrote:
> The PMIC's interrupt is level low and should be pulled up.  The PMIC's device
> node had pinctrl-0 property but it lacked pinctrl-names which is required to
> apply the pin configuration.
> 
> Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> Fixes: aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts
> to a common dtsi")
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>

Please tag me with the whole patch set, thanks.
Reviewed-by: Robin Gong <yibin.gong at nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index f305a530ff6f..521eb3a5a12e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -121,6 +121,7 @@
>  	pmic at 4b {
>  		compatible = "rohm,bd71847";
>  		reg = <0x4b>;
> +		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_pmic>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1




More information about the linux-arm-kernel mailing list