[PATCH] mmc: host: fix depends for MMC_MESON_GX w/ COMPILE_TEST

Krzysztof Kozlowski krzk at kernel.org
Fri Sep 25 13:04:49 EDT 2020

On Fri, Sep 25, 2020 at 09:43:23AM -0700, Randy Dunlap wrote:
> Fix build errors for meson-gx-mmc.c when CONFIG_COMMON_CLK is not
> set/enabled. This can happen when COMPILE_TEST is set/enabled.
> ERROR: modpost: "clk_divider_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "clk_mux_ops" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> ERROR: modpost: "__clk_get_name" [drivers/mmc/host/meson-gx-mmc.ko] undefined!
> Fixes: 54d8454436a2 ("mmc: host: Enable compile testing of multiple drivers")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Kevin Hilman <khilman at baylibre.com>
> Cc: linux-amlogic at lists.infradead.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Ulf Hansson <ulf.hansson at linaro.org>
> Cc: linux-mmc at vger.kernel.org
> Cc: Krzysztof Kozlowski <krzk at kernel.org>
> ---
>  drivers/mmc/host/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> --- linux-next-20200925.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20200925/drivers/mmc/host/Kconfig
> @@ -425,6 +425,7 @@ config MMC_SDHCI_IPROC
>  config MMC_MESON_GX
>  	tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support"
>  	depends on ARCH_MESON|| COMPILE_TEST
> +	depends on COMMON_CLK

I received a report from kbuild about this when I posted the patchset
but somehow I was not able to reproduce it... or I skipped this for
reason I do not remember now, my bad.

Anyway, thanks for fixing, looks ok:
Reviewed-by: Krzysztof Kozlowski <krzk at kernel.org>

Also please for the credits (as Kbuild did report it to me):
Reported-by: kernel test robot <lkp at intel.com>

Best regards,

>  	help
>  	  This selects support for the Amlogic SD/MMC Host Controller
>  	  found on the S905/GX*/AXG family of SoCs.  This controller is

More information about the linux-arm-kernel mailing list