[PATCH v3 24/39] arm64: mte: Add in-kernel MTE helpers
vincenzo.frascino at arm.com
Fri Sep 25 09:36:29 EDT 2020
On 9/25/20 1:50 PM, Catalin Marinas wrote:
>>>> + */
>>>> + /* if (src == NULL) return; */
>>>> + cbz x0, 2f
>>>> + /* if (size == 0) return; */
>>>> + cbz x1, 2f
>>> I find these checks unnecessary, as I said a couple of times before,
>>> just document the function pre-conditions. They are also incomplete
>>> (i.e. you check for NULL but not alignment).
>> I thought we agreed to harden the code further, based on . Maybe I
>> misunderstood. I am going to remove them and extend the comment in the next version.
> Well, you concluded that but I haven't confirmed ;). Since it's called
> from a single place which does the checks already, I don't see the point
> in duplicating them. Documenting should be sufficient.
Have you ever heard about "tacit consent"? ;) Anw, fine by me, I will add a
More information about the linux-arm-kernel