[PATCH 31/42] mfd: timberdale: use PLATFORM_DEVID_NONE

Krzysztof Kozlowski krzk at kernel.org
Mon Sep 21 16:50:05 EDT 2020


Use PLATFORM_DEVID_NONE define instead of "-1" value because:
 - it brings some meaning,
 - it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
---
 drivers/mfd/timberdale.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
index faecbca6dba3..de1589fa2120 100644
--- a/drivers/mfd/timberdale.c
+++ b/drivers/mfd/timberdale.c
@@ -740,25 +740,25 @@ static int timb_probe(struct pci_dev *dev,
 	ip_setup = priv->fw.config & TIMB_HW_VER_MASK;
 	switch (ip_setup) {
 	case TIMB_HW_VER0:
-		err = mfd_add_devices(&dev->dev, -1,
+		err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE,
 			timberdale_cells_bar0_cfg0,
 			ARRAY_SIZE(timberdale_cells_bar0_cfg0),
 			&dev->resource[0], msix_entries[0].vector, NULL);
 		break;
 	case TIMB_HW_VER1:
-		err = mfd_add_devices(&dev->dev, -1,
+		err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE,
 			timberdale_cells_bar0_cfg1,
 			ARRAY_SIZE(timberdale_cells_bar0_cfg1),
 			&dev->resource[0], msix_entries[0].vector, NULL);
 		break;
 	case TIMB_HW_VER2:
-		err = mfd_add_devices(&dev->dev, -1,
+		err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE,
 			timberdale_cells_bar0_cfg2,
 			ARRAY_SIZE(timberdale_cells_bar0_cfg2),
 			&dev->resource[0], msix_entries[0].vector, NULL);
 		break;
 	case TIMB_HW_VER3:
-		err = mfd_add_devices(&dev->dev, -1,
+		err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE,
 			timberdale_cells_bar0_cfg3,
 			ARRAY_SIZE(timberdale_cells_bar0_cfg3),
 			&dev->resource[0], msix_entries[0].vector, NULL);
-- 
2.17.1




More information about the linux-arm-kernel mailing list