IMX6/7 failed to boot due to PCIE changes

Aisheng Dong aisheng.dong at nxp.com
Sun Sep 20 23:00:07 EDT 2020


> From: Jingoo Han <jingoohan1 at gmail.com>
> Sent: Sunday, September 20, 2020 2:58 AM
> On 9/17/20, 6:53 AM, Aisheng Dong wrote:
> > Hi Rob,
> >
> > We found many MX6/7 boards board failed to boot with latest linux-next
> kernel recently.
> > By doing bisect, the issue seems to be related with below two PCIE changes.
> > c2b0c098fbd1 PCI: dwc: Use generic config accessors
> > 7975c8cc8ed8 PCI: dwc: Remove dwc specific config accessor ops
> 
> Dear Dong,
> 
> Recently, Rob shared the following patch. Would you apply and test it? I think
> that it will fix your issue.

Yes, it works.
May I know where is Rob's patch?
I'd like to provide a test-by.

Regards
Aisheng

> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c
> b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 317ff512f8df..afee1a0e8883 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -441,6 +441,9 @@ static void __iomem
> *dw_pcie_other_conf_map_bus(struct pci_bus *bus,
>         struct pcie_port *pp = bus->sysdata;
>         struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> 
> +       if (!dw_pcie_link_up(pci))
> +               return NULL;
> +
>         busdev = PCIE_ATU_BUS(bus->number) |
> PCIE_ATU_DEV(PCI_SLOT(devfn)) |
>                  PCIE_ATU_FUNC(PCI_FUNC(devfn));
> 
> [.....]
> 
> Thank you.
> 
> Best regards,
> Jingoo Han


More information about the linux-arm-kernel mailing list